[OGUI-1773] Handle token validation for p2p connections#3085
Open
OmegaCreations wants to merge 136 commits intodevfrom
Open
[OGUI-1773] Handle token validation for p2p connections#3085OmegaCreations wants to merge 136 commits intodevfrom
OmegaCreations wants to merge 136 commits intodevfrom
Conversation
…sending connections in ConnectionManager
…liceO2Group/WebUi into feature/TKN/OGUI-1703/basic-typescript-interfaces
…liceO2Group/WebUi into feature/TKN/OGUI-1703/basic-typescript-interfaces
…ithub.com:AliceO2Group/WebUi into feature/TKN/OGUI-1704/data-serialization-utils
…ub.com:AliceO2Group/WebUi into feature/TKN/OGUI-1705/client-central-basic-stream
…github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1754/create-reconnection-scheduler
… github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1755/secure-connections-with-certificates
…tes' of github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1773/handle-token-validation-for-p2p-connections
…onnections' of github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1773/handle-token-validation-for-p2p-connections
…OGUI-1755/secure-connections-with-certificates
…tes' of github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1773/handle-token-validation-for-p2p-connections
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...backend/wrapper/src/test/client/ConnectionManager/Interceptors/grpc.auth.interceptor.test.ts
Fixed
Show fixed
Hide fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
In the scope of this task I have created a custom auth "interceptor" (in grpc-js there is no easy way to create interceptors for listeners/servers). It goes through every important step of authentication and authorization before processing with request. In the scope of another tasks there should be added:
I have also moved certificates to the SecurityContext class for more readability. I was wondering if .env would be better then DI, but someone might create multiple instances on the same machine therefore dependency injection is way better solution.